Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter rule enforcing makeStyles' "name" property usage #288

Merged
merged 7 commits into from
Dec 4, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it helps to maintain code and DOM clean.
Also adds fixer, so all files with errors are now fixed.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #288 into master will increase coverage by 0.43%.
The diff coverage is 99.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   73.93%   74.36%   +0.43%     
==========================================
  Files         606      606              
  Lines        6525     6644     +119     
  Branches     1072     1072              
==========================================
+ Hits         4824     4941     +117     
- Misses       1514     1516       +2     
  Partials      187      187
Impacted Files Coverage Δ
src/components/ConfirmButton/ConfirmButton.tsx 10.71% <100%> (ø) ⬆️
...mponents/DiscountCategories/DiscountCategories.tsx 83.33% <100%> (+0.72%) ⬆️
...pleteSelectField/SingleAutocompleteSelectField.tsx 82.14% <100%> (ø) ⬆️
src/components/Checkbox/Checkbox.tsx 78.57% <100%> (+1.64%) ⬆️
...components/CustomerAddresses/CustomerAddresses.tsx 100% <100%> (ø) ⬆️
...s/components/ProductTypeTaxes/ProductTypeTaxes.tsx 100% <100%> (ø) ⬆️
.../webhooks/components/WebhooksList/WebhooksList.tsx 95% <100%> (+0.26%) ⬆️
src/orders/components/OrderList/OrderList.tsx 92.85% <100%> (+0.26%) ⬆️
src/components/PageHeader/PageHeader.tsx 100% <100%> (ø) ⬆️
src/components/PhoneField/PhoneField.tsx 100% <100%> (ø) ⬆️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fefa22...2909a9c. Read the comment docs.

@maarcingebala maarcingebala merged commit c151961 into master Dec 4, 2019
@maarcingebala maarcingebala deleted the add/named-styles-rule branch December 4, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants