Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reset own password #289

Merged
merged 12 commits into from
Dec 4, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resolves #283

Screenshots

Screenshot 2019-12-03 at 17 46 06

Screenshot 2019-12-03 at 17 46 28

Screenshot 2019-12-03 at 17 46 36

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #289 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   74.36%   74.37%   +<.01%     
==========================================
  Files         606      607       +1     
  Lines        6644     6650       +6     
  Branches     1072     1073       +1     
==========================================
+ Hits         4941     4946       +5     
- Misses       1516     1517       +1     
  Partials      187      187
Impacted Files Coverage Δ
src/staff/urls.ts 85.71% <ø> (ø) ⬆️
src/storybook/stories/staff/StaffDetailsPage.tsx 50% <0%> (-4.55%) ⬇️
...c/staff/components/StaffPassword/StaffPassword.tsx 100% <100%> (ø)
...f/components/StaffDetailsPage/StaffDetailsPage.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c151961...44bb4be. Read the comment docs.

@maarcingebala
Copy link
Member

maarcingebala commented Dec 4, 2019

Screenshot 2019-12-04 at 09 56 30

@dominik-zeglen Please fix the copy-pasted modal title 👀. Also - there are 174 files changed which makes it impossible to review. Please update the PR to only include changes related to this feature. If there are any code-style changes related to Eslint, we should do them in a separate PR.

@dominik-zeglen dominik-zeglen force-pushed the add/staff-password-reset branch from f4d1ed8 to 214a44d Compare December 4, 2019 10:16
@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for saleor-dashboard-stage processing.

Building with commit 44bb4be

https://app.netlify.com/sites/saleor-dashboard-stage/deploys/5de7c02f945adc000820c336

Copy link
Member

@tomaszszymanski129 tomaszszymanski129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things

@maarcingebala maarcingebala merged commit 7090148 into master Dec 4, 2019
@maarcingebala maarcingebala deleted the add/staff-password-reset branch May 4, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change staff user's password
3 participants