Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated fields #357

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it uses up to date API fields instead of the deprecated ones.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #357 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   72.88%   72.88%   +<.01%     
==========================================
  Files         612      612              
  Lines        6833     6834       +1     
  Branches     1139     1139              
==========================================
+ Hits         4980     4981       +1     
  Misses       1620     1620              
  Partials      233      233
Impacted Files Coverage Δ
...ts/OrderProductAddDialog/OrderProductAddDialog.tsx 65.78% <ø> (ø) ⬆️
...components/VoucherCreatePage/VoucherCreatePage.tsx 87.5% <ø> (ø) ⬆️
src/home/fixtures.ts 100% <ø> (ø) ⬆️
.../storybook/stories/discounts/VoucherCreatePage.tsx 66.66% <ø> (ø) ⬆️
...storybook/stories/discounts/VoucherDetailsPage.tsx 25% <ø> (ø) ⬆️
src/discounts/fixtures.ts 100% <ø> (ø) ⬆️
...ebhooks/components/WebhookEvents/WebhookEvents.tsx 81.81% <ø> (ø) ⬆️
src/products/fixtures.ts 90% <ø> (ø) ⬆️
...onents/VoucherRequirements/VoucherRequirements.tsx 88.88% <ø> (ø) ⬆️
src/navigation/fixtures.ts 100% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8a141...e3930e7. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 10cd3ab into master Jan 9, 2020
@dominik-zeglen dominik-zeglen deleted the ref/stop-using-deprecated branch January 9, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant