Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to views #361

Merged
merged 85 commits into from
Jan 20, 2020
Merged

Add filtering to views #361

merged 85 commits into from
Jan 20, 2020

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Jan 10, 2020

I want to merge this change because it adds missing filters to views. It also refactors UI and logic.

Screenshots

Screenshot 2019-12-27 at 14 11 50

Screenshot 2019-12-27 at 14 11 58

Screenshot 2019-12-27 at 14 12 13

Screenshot 2019-12-27 at 14 12 22

Screenshot 2019-12-27 at 14 12 38

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented Jan 10, 2020

Deploy preview for saleor-dashboard-stage processing.

Building with commit 4aa188f

https://app.netlify.com/sites/saleor-dashboard-stage/deploys/5e25d05a1062c500084f5c87

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #361 into master will decrease coverage by 0.41%.
The diff coverage is 56.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   72.88%   72.46%   -0.42%     
==========================================
  Files         612      639      +27     
  Lines        6834     7115     +281     
  Branches     1138     1182      +44     
==========================================
+ Hits         4981     5156     +175     
- Misses       1620     1718      +98     
- Partials      233      241       +8
Impacted Files Coverage Δ
src/plugins/urls.ts 85.71% <ø> (ø) ⬆️
...onents/ServiceListPage/ServiceListPage.stories.tsx 71.42% <ø> (ø) ⬆️
src/storybook/stories/staff/StaffListPage.tsx 80% <ø> (ø) ⬆️
src/storybook/stories/products/ProductListPage.tsx 100% <ø> (ø) ⬆️
...nents/WebhooksListPage/WebhookListPage.stories.tsx 71.42% <ø> (ø) ⬆️
src/storybook/stories/discounts/SaleListPage.tsx 100% <ø> (ø) ⬆️
src/plugins/queries.ts 100% <ø> (ø) ⬆️
src/discounts/urls.ts 78.94% <ø> (ø) ⬆️
...components/SingleSelectField/SingleSelectField.tsx 93.33% <ø> (ø) ⬆️
...orybook/stories/collections/CollectionListPage.tsx 100% <ø> (ø) ⬆️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbaaf0...4aa188f. Read the comment docs.

@maarcingebala maarcingebala marked this pull request as ready for review January 20, 2020 15:40
@maarcingebala maarcingebala merged commit 8ed08d1 into master Jan 20, 2020
@maarcingebala maarcingebala deleted the next/filtering branch January 20, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants