Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render password change if authenticating #378

Merged
merged 3 commits into from
Jan 21, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it improves UI a little bit by not showing view that is restricted.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #378 into master will decrease coverage by 0.41%.
The diff coverage is 56.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   72.87%   72.45%   -0.42%     
==========================================
  Files         612      639      +27     
  Lines        6835     7116     +281     
  Branches     1139     1183      +44     
==========================================
+ Hits         4981     5156     +175     
- Misses       1621     1719      +98     
- Partials      233      241       +8
Impacted Files Coverage Δ
src/plugins/urls.ts 85.71% <ø> (ø) ⬆️
...onents/ServiceListPage/ServiceListPage.stories.tsx 71.42% <ø> (ø) ⬆️
src/storybook/stories/staff/StaffListPage.tsx 80% <ø> (ø) ⬆️
src/storybook/stories/products/ProductListPage.tsx 100% <ø> (ø) ⬆️
...nents/WebhooksListPage/WebhookListPage.stories.tsx 71.42% <ø> (ø) ⬆️
src/storybook/stories/discounts/SaleListPage.tsx 100% <ø> (ø) ⬆️
src/plugins/queries.ts 100% <ø> (ø) ⬆️
src/discounts/urls.ts 78.94% <ø> (ø) ⬆️
...components/SingleSelectField/SingleSelectField.tsx 93.33% <ø> (ø) ⬆️
...orybook/stories/collections/CollectionListPage.tsx 100% <ø> (ø) ⬆️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74f2c5...95df0e8. Read the comment docs.

@maarcingebala maarcingebala merged commit 4633714 into master Jan 21, 2020
@maarcingebala maarcingebala deleted the fix/password-reset branch January 21, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants