Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve product update form error handling #392

Merged
merged 4 commits into from
Feb 12, 2020

Conversation

dominik-zeglen
Copy link
Contributor

Resolves #386

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #392 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   72.45%   72.46%           
=======================================
  Files         639      639           
  Lines        7116     7118    +2     
  Branches     1183     1184    +1     
=======================================
+ Hits         5156     5158    +2     
  Misses       1719     1719           
  Partials      241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7790fef...5975131. Read the comment docs.

@maarcingebala maarcingebala merged commit 61d5c24 into master Feb 12, 2020
@maarcingebala maarcingebala deleted the fix/publish-error-indicator branch February 12, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors while saving product are not handled correctly
2 participants