Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rich text editor content error #395

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes #356

Screenshots

Screenshot 2020-02-03 at 12 19 12

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #395 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   72.53%   72.52%   -0.01%     
==========================================
  Files         639      639              
  Lines        7122     7124       +2     
  Branches     1181     1181              
==========================================
+ Hits         5166     5167       +1     
- Misses       1718     1719       +1     
  Partials      238      238
Impacted Files Coverage Δ
src/components/RichTextEditor/RichTextEditor.tsx 73.33% <60%> (-3.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd73e69...291dad7. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 4c8cce4 into master Mar 3, 2020
@dominik-zeglen dominik-zeglen deleted the fix/rich-text-error branch March 3, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't view product details for product with incorrect descriptionJson
2 participants