Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional chaining and explicitely return "Not found" page #408

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds optional chaining and fixes not found error handling.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files         639      639           
  Lines        7120     7120           
  Branches     1180     1180           
=======================================
  Hits         5161     5161           
  Misses       1718     1718           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef8db6...07d3df6. Read the comment docs.

@maarcingebala maarcingebala merged commit 15bdebf into master Feb 21, 2020
@maarcingebala maarcingebala deleted the ref/fix-not-found-handling branch February 21, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants