Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset state after closing #456

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resets form state after leaving the dialog.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #456 into master will increase coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   72.34%   72.52%   +0.18%     
==========================================
  Files         658      639      -19     
  Lines        7426     7126     -300     
  Branches     1225     1181      -44     
==========================================
- Hits         5372     5168     -204     
+ Misses       1817     1720      -97     
- Partials      237      238       +1
Impacted Files Coverage Δ
...ts/OrderProductAddDialog/OrderProductAddDialog.tsx 65% <50%> (-3.3%) ⬇️
...mponents/OrderPaymentDialog/OrderPaymentDialog.tsx 40% <0%> (-14.55%) ⬇️
...onents/ProductVariantStock/ProductVariantStock.tsx 90% <0%> (-10%) ⬇️
.../ShippingZoneRateDialog/ShippingZoneRateDialog.tsx 47.61% <0%> (-9.53%) ⬇️
...c/storybook/stories/navigation/MenuDetailsPage.tsx 45.45% <0%> (-8.4%) ⬇️
...rybook/stories/shipping/ShippingZoneCreatePage.tsx 66.66% <0%> (-8.34%) ⬇️
...ybook/stories/collections/CollectionCreatePage.tsx 66.66% <0%> (-8.34%) ⬇️
...torybook/stories/categories/CategoryCreatePage.tsx 66.66% <0%> (-8.34%) ⬇️
...storybook/stories/orders/OrderProductAddDialog.tsx 50% <0%> (-7.15%) ⬇️
...ebhookDeleteDialog/WebhookDeleteDialog.stories.tsx 60% <0%> (-6.67%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0236597...3f8f3f2. Read the comment docs.

@dominik-zeglen dominik-zeglen force-pushed the fix/draft-add-product-reset branch from 3ee5adb to 3f8f3f2 Compare April 6, 2020 09:17
@dominik-zeglen dominik-zeglen merged commit 74ba8e1 into master Apr 6, 2020
@dominik-zeglen dominik-zeglen deleted the fix/draft-add-product-reset branch April 6, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants