Display validation errors on NewPassword page #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 72.33% 72.35% +0.01%
==========================================
Files 658 658
Lines 7428 7436 +8
Branches 1225 1227 +2
==========================================
+ Hits 5373 5380 +7
- Misses 1818 1819 +1
Partials 237 237
Continue to review full report at Codecov.
|
dominik-zeglen
suggested changes
Apr 7, 2020
src/auth/views/NewPassword.tsx
Outdated
| import { NewPasswordUrlQueryParams } from "../urls"; | ||
|
|
||
| const NewPassword: React.FC<RouteComponentProps> = ({ location }) => { | ||
| const navigate = useNavigator(); | ||
| const { loginByToken } = useUser(); | ||
| const [errors, setErrors] = React.useState< |
There was a problem hiding this comment.
The state here is not needed. SetPasswordMutation returns setPasswordOpts, which has data property, allowing us to access data.setPassword.errors, which we can directly convey to NewPasswordPage as prop. I'll look like this
<NewPasswordPage
errors={setPasswordOpts.data.?.setPassword.errors || []}
...
/>
There was a problem hiding this comment.
You're right. done.
Thank you ;)
dominik-zeglen
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it displays the validation errors on the New Password Page.
fix #468
Screenshots
Pull Request Checklist