Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Is Published column correctly in main Product Listing #475

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Display Is Published column correctly in main Product Listing #475

merged 4 commits into from
Apr 14, 2020

Conversation

gabmartinez
Copy link
Contributor

@gabmartinez gabmartinez commented Apr 11, 2020

I want to merge this change because use the isPublished instead of isAvailabled property in the main Product Listing.

resolve #426

Screenshots

Main Product Listing

Collection Product Listing

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #475 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   72.35%   72.39%   +0.04%     
==========================================
  Files         658      658              
  Lines        7436     7440       +4     
  Branches     1227     1227              
==========================================
+ Hits         5380     5386       +6     
  Misses       1819     1819              
+ Partials      237      235       -2     
Impacted Files Coverage Δ
src/products/fixtures.ts 90.00% <ø> (ø)
...rc/products/components/ProductList/ProductList.tsx 56.60% <100.00%> (+3.77%) ⬆️
src/storybook/stories/products/ProductListPage.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0507811...910f721. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 01d9545 into saleor:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Published column in product list doesn't show correctly if product is_published
3 participants