Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle untracked products #523

Merged
merged 3 commits into from
May 11, 2020
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it handles variants that has inventory tracking disabled.

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-05-08 at 15 37 52

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #523 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   72.00%   72.01%   +0.01%     
==========================================
  Files         709      709              
  Lines        8134     8137       +3     
  Branches     1335     1337       +2     
==========================================
+ Hits         5857     5860       +3     
  Misses       2020     2020              
  Partials      257      257              
Impacted Files Coverage Δ
src/orders/components/OrderFulfillPage/fixtures.ts 100.00% <ø> (ø)
src/orders/queries.ts 100.00% <ø> (ø)
...s/components/OrderFulfillPage/OrderFulfillPage.tsx 91.83% <80.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807f9c1...101341c. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 7f9c6f6 into master May 11, 2020
@dominik-zeglen dominik-zeglen deleted the fix/untracked-products-fulfiillment branch May 11, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants