Add paragraph about manual discount deletion in combination with vouchers #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
13 tasks
zedzior
force-pushed
the
shopx-1585-manual-discount-with-voucher
branch
from
0f11e07
to
d045876
Compare
zedzior
force-pushed
the
shopx-1585-manual-discount-with-voucher
branch
from
d045876
to
44b7297
Compare
IKarbowiak
reviewed
Nov 26, 2024
zedzior
force-pushed
the
shopx-1585-manual-discount-with-voucher
branch
from
44b7297
to
ef062e9
Compare
IKarbowiak
previously approved these changes
Nov 26, 2024
korycins
reviewed
Nov 27, 2024
| ### Manual discounts with vouchers | ||
|
|
||
| Manual discounts take precedence over vouchers, overriding them when applied. However, this does not entirely dissociate the voucher from the order. | ||
| For example, if the manual discount is removed, the system reevaluates the voucher code associated with the order. |
There was a problem hiding this comment.
Wouldn't be good to be more explicit here?
What does reevaluates mean here? Does it mean, that the same voucher amount will be assigned back to the order? Or will the voucher amount be calculated based on the current order (like staff user modified lines/shipping method which changed the prices)?
Does the reevaluation use de-normalized values assigned to the order? Will the flow be the same when voucher instance exists/was deleted in the meantime?
IKarbowiak
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds paragraph about manual discount deletion in combination with vouchers