Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Added missing product attributes #536

Merged
merged 7 commits into from
Dec 19, 2019
Merged

Added missing product attributes #536

merged 7 commits into from
Dec 19, 2019

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Dec 17, 2019 •
edited
Loading

I want to merge this change because it adds missing product attributes in product view

Screenshots

Before:
Zrzut ekranu 2019-12-17 o 17 18 19

After:
Zrzut ekranu 2019-12-17 o 17 17 31

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@orzechdev orzechdev changed the title Feature/missing product attributes Added missing product attributes Dec 17, 2019
@orzechdev orzechdev force-pushed the feature/missing_product_attributes branch from 8d1946a to 6beea9f Compare December 19, 2019 09:25
@orzechdev orzechdev marked this pull request as ready for review December 19, 2019 09:43
@maarcingebala maarcingebala merged commit b543c00 into master Dec 19, 2019
@maarcingebala maarcingebala deleted the feature/missing_product_attributes branch December 19, 2019 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mateuszkula mateuszkula mateuszkula approved these changes

@maarcingebala maarcingebala maarcingebala approved these changes

@jwm0 jwm0 Awaiting requested review from jwm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orzechdev @maarcingebala @mateuszkula