Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout funds releasing task #17236

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

IKarbowiak
Copy link
Member

Fix checkout funds releasing.
Missing authorized_value and charged_value in filters causes the task to clog, we were fetching still the same checkouts with transactions that cannot be released.

Port of #17198

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@IKarbowiak IKarbowiak self-assigned this Jan 10, 2025
* Fix checkout funds releasing task

* Fix changelog

* Fix typo in CORE_2118 e2e

* Apply code review suggestions

* Improve logs
@IKarbowiak IKarbowiak force-pushed the shopx-1745-fix-checkout-releasing-funds-3.17 branch from be077e7 to e2f370f Compare January 10, 2025 12:25
@db-queries
Copy link

db-queries bot commented Jan 10, 2025

Here is the report for e2f370f (saleor:shopx-1745-fix-checkout-releasing-funds-3.17)
Missing base report (e9b7110). The results couldn't be compared.

No differences were found.

@IKarbowiak IKarbowiak marked this pull request as draft January 13, 2025 13:42
@IKarbowiak IKarbowiak marked this pull request as ready for review January 15, 2025 11:20
@IKarbowiak IKarbowiak requested a review from a team January 15, 2025 11:25
@fowczarek fowczarek requested a review from a team January 16, 2025 09:46
@IKarbowiak IKarbowiak merged commit ce27ce8 into 3.17 Jan 17, 2025
3 checks passed
@IKarbowiak IKarbowiak deleted the shopx-1745-fix-checkout-releasing-funds-3.17 branch January 17, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants