Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation to change user email #5076

Merged

Conversation

kswiatek92
Copy link

@kswiatek92 kswiatek92 commented Dec 17, 2019

closes #4648

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #5076 into master will increase coverage by 0.03%.
The diff coverage is 97.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5076      +/-   ##
==========================================
+ Coverage   91.53%   91.56%   +0.03%     
==========================================
  Files         260      260              
  Lines       16717    16802      +85     
  Branches     1469     1472       +3     
==========================================
+ Hits        15302    15385      +83     
- Misses       1034     1035       +1     
- Partials      381      382       +1
Impacted Files Coverage Δ
saleor/account/events.py 100% <100%> (ø) ⬆️
saleor/account/emails.py 89.39% <100%> (+4.94%) ⬆️
saleor/graphql/account/schema.py 100% <100%> (ø) ⬆️
saleor/graphql/account/mutations/account.py 99.15% <96.55%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34b31e...8e875bf. Read the comment docs.

Copy link

django-queries commented Dec 17, 2019

Here is the report for 8e875bf (kswiatek92/saleor @ mutation-to-change-user-email)
Base comparison is b34b31e.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         14	         14	              2
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         16	         16	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 8 times, most recently from 15ee3ca to 1cc81db Compare December 19, 2019 15:46
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 7 times, most recently from c8e2868 to 5070ba8 Compare January 3, 2020 10:45
@kswiatek92 kswiatek92 requested a review from NyanKiyoshi January 3, 2020 10:45
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 4 times, most recently from 089d370 to 3a63ae3 Compare January 3, 2020 12:05
@kswiatek92 kswiatek92 requested a review from fowczarek January 3, 2020 12:22
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 3 times, most recently from e9a01d4 to d839c10 Compare January 3, 2020 14:03
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 2 times, most recently from 6d16cd6 to 847a7fa Compare January 7, 2020 09:29
@kswiatek92 kswiatek92 marked this pull request as ready for review January 7, 2020 09:40
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 2 times, most recently from 844adce to 97d85df Compare January 8, 2020 10:13
saleor/account/__init__.py Outdated Show resolved Hide resolved
saleor/account/emails.py Outdated Show resolved Hide resolved
saleor/account/utils.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/account.py Show resolved Hide resolved
saleor/account/emails.py Outdated Show resolved Hide resolved
saleor/account/emails.py Outdated Show resolved Hide resolved
saleor/account/emails.py Outdated Show resolved Hide resolved
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 4 times, most recently from f0302a1 to b6ba341 Compare January 8, 2020 19:53
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch 4 times, most recently from 8ead53b to 99189ac Compare January 9, 2020 10:16
@kswiatek92 kswiatek92 force-pushed the mutation-to-change-user-email branch from 99189ac to 8e875bf Compare January 9, 2020 10:21
@maarcingebala maarcingebala merged commit 9ac4ee9 into saleor:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation to change user email
3 participants