-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #5107
Remove deprecated code #5107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5107 +/- ##
========================================
Coverage ? 91%
========================================
Files ? 259
Lines ? 16751
Branches ? 1489
========================================
Hits ? 15245
Misses ? 1103
Partials ? 403
Continue to review full report at Codecov.
|
Here is the report for ce15c4c (mirumee/saleor @ remove-deprecated-code) **Found 2 differences!** (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
+ product details 15 14 2
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
- retrieve variant list 15 16 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Drop deprecated code that was marked for being removed in 2.10.
Pull Request Checklist