Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #5107

Merged
merged 14 commits into from
Jan 7, 2020
Merged

Remove deprecated code #5107

merged 14 commits into from
Jan 7, 2020

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Dec 23, 2019

Drop deprecated code that was marked for being removed in 2.10.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak self-assigned this Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c47336f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5107   +/-   ##
========================================
  Coverage          ?     91%           
========================================
  Files             ?     259           
  Lines             ?   16751           
  Branches          ?    1489           
========================================
  Hits              ?   15245           
  Misses            ?    1103           
  Partials          ?     403
Impacted Files Coverage Δ
saleor/product/utils/availability.py 95.34% <ø> (ø)
saleor/product/utils/costs.py 81.81% <ø> (ø)
saleor/graphql/product/resolvers.py 85.32% <100%> (ø)
saleor/search/backends/postgresql_storefront.py 100% <100%> (ø)
saleor/graphql/checkout/mutations.py 94.15% <100%> (ø)
saleor/graphql/discount/filters.py 90% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47336f...ce15c4c. Read the comment docs.

Copy link

django-queries commented Dec 23, 2019

Here is the report for ce15c4c (mirumee/saleor @ remove-deprecated-code)
Base comparison is e8416de.

**Found 2 differences!** (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
+ product details                            	         15	         14	              2
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
- retrieve variant list                      	         15	         16	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

tests/api/test_product.py Outdated Show resolved Hide resolved
tests/api/test_product.py Outdated Show resolved Hide resolved
tests/api/test_product.py Outdated Show resolved Hide resolved
tests/api/test_product.py Outdated Show resolved Hide resolved
@fowczarek fowczarek self-requested a review January 2, 2020 06:44
@maarcingebala maarcingebala merged commit 187facf into master Jan 7, 2020
@maarcingebala maarcingebala deleted the remove-deprecated-code branch January 7, 2020 13:59
@maarcingebala maarcingebala mentioned this pull request Jan 23, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants