Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move product_created execution after M2M saving #5187

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Move product_created execution after M2M saving #5187

merged 4 commits into from
Jan 23, 2020

Conversation

dzkb
Copy link
Contributor

@dzkb dzkb commented Jan 22, 2020

I want to merge this change because it fixes #5169.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8bf7f9f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5187   +/-   ##
=========================================
  Coverage          ?   91.82%           
=========================================
  Files             ?      270           
  Lines             ?    17521           
  Branches          ?     1513           
=========================================
  Hits              ?    16088           
  Misses            ?     1039           
  Partials          ?      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf7f9f...bc7b0a8. Read the comment docs.

Copy link

django-queries commented Jan 22, 2020

Here is the report for 8bf7f9f (dzkb/saleor @ fix/product-created-payload)
Base comparison is 7f67c75.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	          5	          5	              1

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         18	         18	              4
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         23	         23	              9

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

):
query = """
mutation createProduct($productTypeId: ID!, $collectionId: ID!, $categoryId: ID!) {
productCreate(input: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of mutations: productCreate in this file. Maybe we could extract some of them to the single fixture or variable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's beyond the scope of this PR. We'll be working on tests refactoring soon and maybe this will be a good chance to improve it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's beyond the scope of this PR. We'll be working on tests refactoring soon and maybe this will be a good chance to improve it.

tests/api/test_product.py Outdated Show resolved Hide resolved
@maarcingebala maarcingebala merged commit dac1787 into saleor:master Jan 23, 2020
@dzkb dzkb deleted the fix/product-created-payload branch January 23, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions: method product_created is executed too early
4 participants