-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move product_created
execution after M2M saving
#5187
Move product_created
execution after M2M saving
#5187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5187 +/- ##
=========================================
Coverage ? 91.82%
=========================================
Files ? 270
Lines ? 17521
Branches ? 1513
=========================================
Hits ? 16088
Misses ? 1039
Partials ? 394 Continue to review full report at Codecov.
|
Here is the report for 8bf7f9f (dzkb/saleor @ fix/product-created-payload) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 5 5 1
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 18 18 4
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 23 23 9
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
): | ||
query = """ | ||
mutation createProduct($productTypeId: ID!, $collectionId: ID!, $categoryId: ID!) { | ||
productCreate(input: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of mutations: productCreate
in this file. Maybe we could extract some of them to the single fixture or variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's beyond the scope of this PR. We'll be working on tests refactoring soon and maybe this will be a good chance to improve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's beyond the scope of this PR. We'll be working on tests refactoring soon and maybe this will be a good chance to improve it.
I want to merge this change because it fixes #5169.
Pull Request Checklist