-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop get_absolute_url methods #5299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the report for aabb48e (mirumee/saleor @ drop-get-absolute-url-methods) No differences were found. (click me)
# api.benchmark category
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
category view 23 23 0
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 5 5 1
# api.benchmark collection
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
collection view 21 21 0
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
featured products list 20 20 0
retrieve main menu 8 8 0
retrieve product list 6 6 0
retrieve secondary menu 8 8 0
retrieve shop 2 2 0
user checkout details 53 53 28
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 17 17 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 23 23 9
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #5299 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 283 283
Lines 18154 18154
Branches 1580 1580
=======================================
Hits 16628 16628
Misses 1103 1103
Partials 423 423 Continue to review full report at Codecov.
|
IKarbowiak
force-pushed
the
drop-get-absolute-url-methods
branch
4 times, most recently
from
February 26, 2020 15:07
e31fc9d
to
44d9abd
Compare
NyanKiyoshi
approved these changes
Feb 26, 2020
NyanKiyoshi
reviewed
Feb 26, 2020
IKarbowiak
force-pushed
the
drop-get-absolute-url-methods
branch
from
February 27, 2020 11:05
44d9abd
to
a58a27e
Compare
IKarbowiak
force-pushed
the
drop-get-absolute-url-methods
branch
from
February 27, 2020 11:14
a58a27e
to
2515752
Compare
NyanKiyoshi
reviewed
Feb 27, 2020
maarcingebala
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5022
Pull Request Checklist