Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop get_absolute_url methods #5299

Merged
merged 5 commits into from
Mar 2, 2020
Merged

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Feb 26, 2020

Resolves #5022

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak self-assigned this Feb 26, 2020
Copy link

django-queries commented Feb 26, 2020

Here is the report for aabb48e (mirumee/saleor @ drop-get-absolute-url-methods)
Base comparison is ba45ef0.

No differences were found. (click me)

# api.benchmark category
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  category view                              	         23	         23	              0

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	          5	          5	              1

# api.benchmark collection
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  collection view                            	         21	         21	              0

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  featured products list                     	         20	         20	              0
  retrieve main menu                         	          8	          8	              0
  retrieve product list                      	          6	          6	              0
  retrieve secondary menu                    	          8	          8	              0
  retrieve shop                              	          2	          2	              0
  user checkout details                      	         53	         53	             28

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         17	         17	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         23	         23	              9

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #5299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5299   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         283      283           
  Lines       18154    18154           
  Branches     1580     1580           
=======================================
  Hits        16628    16628           
  Misses       1103     1103           
  Partials      423      423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413cfb1...aabb48e. Read the comment docs.

@IKarbowiak IKarbowiak force-pushed the drop-get-absolute-url-methods branch 4 times, most recently from e31fc9d to 44d9abd Compare February 26, 2020 15:07
@IKarbowiak IKarbowiak force-pushed the drop-get-absolute-url-methods branch from 44d9abd to a58a27e Compare February 27, 2020 11:05
@IKarbowiak IKarbowiak force-pushed the drop-get-absolute-url-methods branch from a58a27e to 2515752 Compare February 27, 2020 11:14
@maarcingebala maarcingebala merged commit 89d0a29 into master Mar 2, 2020
@maarcingebala maarcingebala deleted the drop-get-absolute-url-methods branch March 2, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove get_absolute_url() functions from models.
4 participants