Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in settings #5420

Merged
merged 6 commits into from
Apr 2, 2020
Merged

Cleanup in settings #5420

merged 6 commits into from
Apr 2, 2020

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Apr 1, 2020

This PR removes unused settings and environment variables.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #5420 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5420      +/-   ##
==========================================
+ Coverage   91.11%   91.13%   +0.01%     
==========================================
  Files         283      283              
  Lines       18331    18327       -4     
  Branches     1608     1607       -1     
==========================================
  Hits        16702    16702              
+ Misses       1200     1196       -4     
  Partials      429      429              
Impacted Files Coverage Δ
saleor/demo/settings.py 0.00% <ø> (ø)
saleor/wsgi/__init__.py 0.00% <ø> (ø)
saleor/product/models.py 91.51% <100.00%> (+0.39%) ⬆️
saleor/core/utils/draftjs.py 30.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86967b7...a6a1cdd. Read the comment docs.

Copy link
Member

@patrys patrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the docs to reflect those?

@maarcingebala
Copy link
Member Author

@patrys Yup I'm working on changes in saleor-docs as well, today or tomorrow I'll push some updates to the saleor-2.10 branch.

@maarcingebala maarcingebala had a problem deploying to saleor-core-settings-cl-yvzbir April 1, 2020 14:35 Failure
@maarcingebala maarcingebala temporarily deployed to saleor-core-settings-cl-yvzbir April 1, 2020 15:32 Inactive
@maarcingebala maarcingebala merged commit 2b5d902 into master Apr 2, 2020
@maarcingebala maarcingebala deleted the settings-cleaning branch April 2, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants