-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed JWT expired token being logged as unhandled error #5603
Conversation
Here is the report for b84a113 (NyanKiyoshi/saleor @ jwt/handle-expired) No differences were found. (click me)
# api.benchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 21 21 4
staff create 24 24 5
staff update groups and permissions 36 36 6
# api.benchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
category view 18 18 1
# api.benchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 52 52 26
add shipping to checkout 40 40 12
checkout email update 29 29 13
checkout payment charge 23 23 5
checkout shipping address update 35 35 8
checkout voucher code 59 59 31
complete checkout 74 74 19
create checkout 140 140 75
update checkout lines 101 101 50
# api.benchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 17 17 0
# api.benchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
featured products list 14 14 0
retrieve main menu 8 8 0
retrieve product list 5 5 0
retrieve secondary menu 8 8 0
retrieve shop 2 2 0
user checkout details 52 52 26
# api.benchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user order details 17 17 2
# api.benchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 21 21 3
permission group delete 22 22 4
permission group query 8 8 0
permission group update 36 36 2
permission group update remove users with manage staff 31 31 4
# api.benchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product details 19 19 2
retrieve product attributes 7 7 0
# api.benchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 48 48 2
retrieve variant list 23 23 6
# api.benchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 23 23 5
product variants stocks delete 20 20 5
product variants stocks update 28 28 5
# api product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 20 20 0 |
Codecov Report
@@ Coverage Diff @@
## master #5603 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 304 304
Lines 19843 19843
Branches 1847 1847
=======================================
Hits 18194 18194
Misses 1215 1215
Partials 434 434
Continue to review full report at Codecov.
|
951c650
to
b84a113
Compare
Why not add time expiration as an environment parameter ?? |
@JrmyDev what do you mean by optional? |
@NyanKiyoshi : I mean we could set JWT_EXPIRATION_DELTA as an environment variable instead of editing settings.py |
I don't really expect users to want to edit that value. Unless there is an actual use case? |
Isn't this parameter the session duration ?? |
The time before the token must be refreshed. |
Ok, sorry i misunderstood... |
No, as long the client refreshes the token, it's all good. |
Closes #5601.
JSONWebTokenExpired
coming from invalid JWT payload;DEBUG
is enable or not (useful for testing each mode);JWT_EXPIRATION_DELTA
as it allows the users to customize it if needed or at least know how long a token stays valid.Impact
Pull Request Checklist