Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadTheDocs documentation build with pyproject.toml #108

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Fix ReadTheDocs documentation build with pyproject.toml #108

merged 4 commits into from
Dec 1, 2022

Conversation

bgrant
Copy link
Collaborator

@bgrant bgrant commented Nov 29, 2022 •
edited
Loading

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to requirements.txt or requirements-dev.txt
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@bgrant bgrant requested a review from demianbrecht November 29, 2022 16:03
demianbrecht
demianbrecht previously approved these changes Nov 30, 2022
View reviewed changes
@bgrant
Copy link
Collaborator Author

bgrant commented Nov 30, 2022

I had to merge conflicts in CHANGELOG.md. Would you mind re-reviewing @demianbrecht ?

@bgrant bgrant requested a review from demianbrecht November 30, 2022 16:35
@bgrant bgrant merged commit 00e5232 into main Dec 1, 2022
@bgrant bgrant deleted the chore/fix-rtd branch December 1, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demianbrecht demianbrecht demianbrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgrant @demianbrecht