Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter caching to work with all data types #134

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix filter caching to work with all data types #134

merged 3 commits into from
Sep 11, 2023

Conversation

dshafer
Copy link
Collaborator

@dshafer dshafer commented Sep 8, 2023 •
edited by bgrant
Loading

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to pyproject.toml
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@dshafer dshafer force-pushed the chore/fix-lambda-caching branch from 206f044 to 6b2277d Compare September 11, 2023 11:47
@bgrant bgrant mentioned this pull request Sep 11, 2023
Closed
6 tasks
bgrant
bgrant reviewed Sep 11, 2023
View reviewed changes
django_declarative_apis/machinery/filtering.py Outdated
cache_relation = False

if cache_relation:
# we're caching a foreign key field on a djano model. Cache it by (model, fk_pk) so that if
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: djano -> django

@bgrant
Copy link
Collaborator

bgrant commented Sep 11, 2023

Would you mind adding a CHANGELOG entry?

@bgrant
Copy link
Collaborator

bgrant commented Sep 11, 2023

QA: makes tests pass on calling code

@bgrant bgrant self-requested a review September 11, 2023 15:12
@dshafer dshafer changed the title only cache if lambda result is a django model Fix filter caching to work with all data types Sep 11, 2023
bgrant
bgrant approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@bgrant bgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dshafer dshafer merged commit de3b2a0 into main Sep 11, 2023
@dshafer dshafer deleted the chore/fix-lambda-caching branch September 11, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant bgrant bgrant approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshafer @bgrant