Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Replace flake8 and black with ruff, add testing for Python 3.12, drop testing for Python 3.7 #143

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

bgrant
Copy link
Collaborator

@bgrant bgrant commented Oct 26, 2023

Changes:

  • Replace flake8 with ruff as the static checker
  • Make code fixes for ruff
  • Remove flake8 dependency and config
  • Replace black with ruff as the code formatter
  • Autoformat with ruff
  • Exclude .heroku directory
  • Add ruff --fix target to makefile as make static-fix
  • Drop testing Python 3.7 and add 3.12 (only test supported Python versions)

I would have split the Python testing changes into a separate PR, but there were issues with Python 3.7 in this PR I didn't want to fix. When I made the Python testing changes a separate PR, our version of flake8 had problems with Python 3.12.

@bgrant bgrant changed the title Testing: Replace flake8 and black with ruff Testing: Replace flake8 and black with ruff, add testing for Python 3.12, drop testing for Python 3.7 Oct 26, 2023
@bgrant bgrant merged commit c6ecfdb into main Oct 26, 2023
5 checks passed
@bgrant bgrant deleted the chore/test-with-ruff branch October 26, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants