flake8 - primarily fix up imports #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demianbrecht
requested changes
Feb 14, 2020
| @@ -21,7 +21,8 @@ def __init__(self): | |||
| "There was a problem with your timestamp. Please check your current system time." | |||
| "Server time is {0}.".format(time.time()) | |||
| ) | |||
| self.auth_header = 'OAuth realm="API",oauth_problem=timestamp_refused&oauth_acceptable_timestamps={0}-{1}'.format( | |||
| header_fmt = 'OAuth realm="API",oauth_problem=timestamp_refused&oauth_acceptable_timestamps={0}-{1}' | |||
There was a problem hiding this comment.
I'd rather just replace this with an f-string if at all possible as we'll be requiring 3.6+
| from . import errors | ||
| from .attributes import * |
There was a problem hiding this comment.
Won't find any arguments from me here.
There was a problem hiding this comment.
Think I should import the rest of the attributes from .attributes (even the ones that aren't used in __init__.py?
There was a problem hiding this comment.
Eh, I'll leave that up to you. I'm not a huge fan of this type of root imports anyways.
There was a problem hiding this comment.
Okay- I'm thinking I should, since I think other packages use machinery as an interface. I'll mark the import line noqa.
bgrant
changed the title
demianbrecht
previously approved these changes
Feb 18, 2020
Previously we imported `*` from `attributes`, so some values from that file may be used in other projects even though they are not used in this file, as it appears `machinery` is used as an interface for `attributes`.
demianbrecht
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*inmachinery.__init__This one might be a bit controversial. The
import *is replaced with a pretty long list of imports, but the*import obscured the fact that some base things likeloggingandabcweren't being imported inmachinery.__init__, they were coming in from theattributesmodule. There are a few attributes that aren't explicitly imported here that I could add to the list if the intention is for this module to be an interface that subsumesattributes.