feat: Creates tests for the example app - Redo #59
Conversation
|
Hey @hmanalai - thanks! A couple of high-level suggestions:
I haven't dug into the substance of your tests yet (hopefully someone more familiar with DDA will), but I verify that they pass! |
|
I'm glad you got the salesforce-cla check figured out! |
There was a problem hiding this comment.
Just a comment about whether or not to keep the model unit tests -- you can take it or leave it. Very nice work @hmanalai!
| @@ -0,0 +1,12 @@ | |||
| COVERAGE_CMD = coverage run manage.py test --noinput && coverage xml && coverage report | |||
There was a problem hiding this comment.
This is great
Great suggestion @bgrant!
| @@ -0,0 +1,21 @@ | |||
| from django.test import TestCase | |||
There was a problem hiding this comment.
I'm not sure that this file is necessary -- for TDD it's great to have these, and they'd be great to have if we were developing the example app for use, but I'm not sure that they have much use as a demonstration.
There was a problem hiding this comment.
When I was first writing the tests I wasn't sure what fields an instance of OAuthConsumer would have, and I thought maybe others would have the same question. That's why I left the model tests. But since we're going to have a documentation, I think we can take it out.
There was a problem hiding this comment.
nope that's a great answer!
Adds three new files that tests example app's models, /me, and /ping endpoints.