Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom files to update #236

Closed
npars opened this issue Jun 4, 2021 · 4 comments
Closed

Add support for custom files to update #236

npars opened this issue Jun 4, 2021 · 4 comments
Assignees

Comments

@npars
Copy link

npars commented Jun 4, 2021

Is your feature request related to a problem? Please describe.
The image updater currently only catches image tags that are in Dockerfiles in our repo. It would be nice if it also updated
docker-compose files so that we would not need to manually push commits to the PRs that the tool creates.

Describe the solution you'd like
Add ability to search for and update docker-compose yaml files in a addition to Dockerfiles. A basic search might be
something like: language:yaml filename:docker-compose "image: docker/image/name". This will miss files that don't
follow the docker-compose file name convention, but that's probably better than searching all yaml files.

Describe alternatives you've considered
N/A

Additional context
N/A

@afalko
Copy link
Collaborator

afalko commented Nov 12, 2021

I'm changing the subject to allow us to pass a list of files we want to scan vs. only supporting Dockerfiles

@afalko afalko changed the title Add support for docker-compose yaml files Add support for custom files to update Nov 12, 2021
@afalko
Copy link
Collaborator

afalko commented Nov 12, 2021

Also while we do this, we should consider supporting wild cards:
Dockerfile-*

@justinharringa
Copy link
Contributor

We already scan all Dockerfile by virtue of using filename:Dockerfile and it will find, for example Dockerfile-somethingelse

@justinharringa
Copy link
Contributor

I believe you'll need to be somewhat specific about parsing / file format as well.

@pchugh17 pchugh17 self-assigned this Dec 7, 2022
afalko pushed a commit that referenced this issue Jan 24, 2023
@afalko afalko closed this as completed in 890e120 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants