Use stream to look for error message prefixes #331
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -21,6 +22,7 @@ | |||
| import java.util.HashMap; | |||
| import java.util.List; | |||
| import java.util.Map; | |||
| import java.util.Arrays; | |||
There was a problem hiding this comment.
Wrong lexicographical order for 'java.util.Arrays' import. Should be before 'org.slf4j.LoggerFactory'.
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
============================================
+ Coverage 81.55% 81.59% +0.03%
Complexity 265 265
============================================
Files 19 19
Lines 938 940 +2
Branches 127 126 -1
============================================
+ Hits 765 767 +2
Misses 142 142
Partials 31 31
|
| String finalError = error; | ||
| List<String> errorPrefixes = Arrays.asList(PR_INVALID_CODE, "No commits between"); | ||
| if (error.startsWith("A pull request already exists")) { |
There was a problem hiding this comment.
Not sure why you need finalError instead of just using error but you should probably use either one or the other in both if statements.
There was a problem hiding this comment.
When I tried using the variable error I got the following warning on IDE
Variable used in lambda expression should be final or effectively final
| // This case usually happens when the PR head has invalid data. Deleting the forked repo resolves it. | ||
| error = PR_INVALID_CODE; | ||
| String error = PR_INVALID_CODE; | ||
| JsonObject errorMessage = errorJson.get(0).getAsJsonObject(); |
There was a problem hiding this comment.
Are there ever more than 1 error in this array? Any reason not to foreach on them?
There was a problem hiding this comment.
Not sure about that. This piece of code has been there for a while.
justinharringa
added
bug
This PR creates an Array of potential error messages and streams through them to check for the existence of one. This way we will not have to modify the conditional check even if there are more error prefixes we add in the future.