updated tag store read/write to blob #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Background : [github-api] GHRepository.getFileContent doesn't support reading/writing a file with size more > 1 MB |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
============================================
+ Coverage 81.75% 82.40% +0.64%
- Complexity 297 300 +3
============================================
Files 23 23
Lines 1058 1074 +16
Branches 135 135
============================================
+ Hits 865 885 +20
+ Misses 159 155 -4
Partials 34 34
|
jeetchoudhary
force-pushed
the
blob-read
branch
from
2241a88 to
13235f3
Compare
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
afalko
reviewed
Aug 31, 2022
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
afalko
reviewed
Aug 31, 2022
| log.info("Image tag store {} is already initialized and have size more than 1 MB" | ||
| , path); | ||
| } else { | ||
| throw ex; |
There was a problem hiding this comment.
I don't think we threw before - just want to make sure this is intended.
There was a problem hiding this comment.
yes, this is intentional. we were throwing it earlier as well just not explicitely.
afalko
reviewed
Aug 31, 2022
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
afalko
reviewed
Aug 31, 2022
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
afalko
reviewed
Aug 31, 2022
afalko
requested changes
Aug 31, 2022
jeetchoudhary
force-pushed
the
blob-read
branch
from
13235f3 to
0802b87
Compare
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
jeetchoudhary
force-pushed
the
blob-read
branch
from
0802b87 to
fac90f8
Compare
jeetchoudhary
force-pushed
the
blob-read
branch
from
fac90f8 to
f8acff5
Compare
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Show resolved
Hide resolved
...image-update/src/main/java/com/salesforce/dockerfileimageupdate/storage/GitHubJsonStore.java
Outdated
Show resolved
Hide resolved
afalko
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Cases:
new store created:
https://git.****.****.com/jitender-kumar/sfci-test/blob/master/store_new.json
store update with sized less < 1 MB
https://git.****.****.com/jitender-kumar/sfci-test/blob/master/store_new.json
store updated with size > 1MB
https://git.****.****.com/jitender-kumar/sfci-test/blob/master/store.json
Benchmarking for reads from the new API:
