Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch all items incase of S3 image tag store #800

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Fetch all items incase of S3 image tag store #800

merged 5 commits into from
Feb 17, 2023

Conversation

tarishij17
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the tests Improvements / maintenance to tests label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #800 (d3a039c) into main (02fcadf) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head d3a039c differs from pull request most recent head 0e0a228. Consider uploading reports for the commit 0e0a228 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #800      +/-   ##
============================================
+ Coverage     84.40%   84.48%   +0.07%     
- Complexity      374      376       +2     
============================================
  Files            27       27              
  Lines          1244     1250       +6     
  Branches        164      166       +2     
============================================
+ Hits           1050     1056       +6     
  Misses          157      157              
  Partials         37       37
Impacted Files Coverage Δ
.../salesforce/dockerfileimageupdate/CommandLine.java 62.60% <ø> (-0.33%) ⬇️
...fileimageupdate/storage/S3BackedImageTagStore.java 96.42% <100.00%> (+0.51%) ⬆️

tarishij17
tarishij17 commented Feb 16, 2023
View reviewed changes
dockerfile-image-update/src/main/java/com/salesforce/dockerfileimageupdate/CommandLine.java
@@ -93,7 +93,6 @@ static ArgumentParser getArgumentParser() {
"(default: Dockerfile,docker-compose)");
parser.addArgument("-r", "--" + RATE_LIMIT_PR_CREATION)
.type(String.class)
.setDefault("")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this default was causing the flow to throw java.util.UnknownFormatConversionException and proceed when rate limiting was not used https://github.com/salesforce/dockerfile-image-update/blob/main/dockerfile-image-update/src/main/java/com/salesforce/dockerfileimageupdate/utils/RateLimit.java#L61
Removing this will make the logging more cleaner and give apt info message when rate limiting not used

afalko
afalko previously approved these changes Feb 16, 2023
View reviewed changes
@afalko afalko requested a review from jeetchoudhary February 16, 2023 21:48
@afalko
Copy link
Collaborator

afalko commented Feb 16, 2023

Added @jeetchoudhary for second opinion - LGTM

@afalko afalko closed this Feb 16, 2023
@afalko afalko reopened this Feb 16, 2023
@afalko
Copy link
Collaborator

afalko commented Feb 16, 2023

Sorry, accidentally pressed close with comment

jeetchoudhary
jeetchoudhary previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@jeetchoudhary jeetchoudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, proposed some minor nit changes. do have a look.

...update/src/main/java/com/salesforce/dockerfileimageupdate/storage/S3BackedImageTagStore.java Outdated Show resolved Hide resolved
...te/src/test/java/com/salesforce/dockerfileimageupdate/storage/S3BackedImageTagStoreTest.java Outdated Show resolved Hide resolved
...te/src/test/java/com/salesforce/dockerfileimageupdate/storage/S3BackedImageTagStoreTest.java Outdated Show resolved Hide resolved
@tarishij17 tarishij17 dismissed stale reviews from jeetchoudhary and afalko via 0e0a228 February 17, 2023 07:32
@tarishij17
Copy link
Contributor Author

Addressed comments. Can you please re-review @afalko @jeetchoudhary

@tarishij17 tarishij17 requested review from afalko and jeetchoudhary and removed request for afalko and jeetchoudhary February 17, 2023 07:34
@afalko afalko merged commit e8b92a5 into salesforce:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeetchoudhary jeetchoudhary jeetchoudhary approved these changes

@afalko afalko afalko approved these changes

@avimanyum avimanyum Awaiting requested review from avimanyum avimanyum is a code owner

Assignees
No one assigned
Labels
cla:signed tests Improvements / maintenance to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarishij17 @afalko @jeetchoudhary