feat: add "dependencies" labels to DFIU-created PRs #983
Conversation
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
============================================
+ Coverage 84.60% 84.62% +0.01%
Complexity 378 378
============================================
Files 27 27
Lines 1254 1255 +1
Branches 166 166
============================================
+ Hits 1061 1062 +1
Misses 157 157
Partials 36 36
|
| @@ -105,6 +105,7 @@ public int createPullReq(GHRepository origRepo, String branch, | |||
| try { | |||
| GHPullRequest pullRequest = origRepo.createPullRequest(title, forkRepo.getOwnerName() + ":" + branch, | |||
| origRepo.getDefaultBranch(), body); | |||
| pullRequest.setLabels("dependencies"); | |||
There was a problem hiding this comment.
can we run it against an org/repo that doesn't have dependencies label already created? Not sure If the will auto-create a new one If it doesn't exist. In the earlier version of GHE, I believe we had to create a label explicitly first and then apply it.
LGTM otherwise
There was a problem hiding this comment.
As I have seen from other tools, the label would be auto-created.
I read https://docs.github.com/en/rest/issues/labels?apiVersion=2022-11-28#about-labels and didn't see anything about the label needing to exist first.
There was a problem hiding this comment.
wanted to be sure about it. vaguely remember this was needed a couple of years back.
Tested it on test-temp/test/pull/1 on soma. works fine. we should be good here
jasonschroeder-sfdc
force-pushed
the
add-pr-labels
branch
from
497fa0a to
f847c41
Compare
This adds "dependencies" label to DFIU-created PRs.