fix(ssr): non-empty text nodes adjacent with comments #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
reviewed
Nov 26, 2024
Comment on lines
48
to
53
| (!cxt.prevSibling || | ||
| (cxt.prevSibling.type !== 'Text' && | ||
| (cxt.templateOptions.preserveComments || cxt.prevSibling.type !== 'Comment'))) && | ||
| (!cxt.nextSibling || | ||
| (cxt.nextSibling.type !== 'Text' && | ||
| (cxt.templateOptions.preserveComments || cxt.nextSibling.type !== 'Comment'))) |
There was a problem hiding this comment.
This is a lot of nesting, can we extract it to a function?
There was a problem hiding this comment.
Beat me to it :) . I'll do that.
There was a problem hiding this comment.
I appreciate what you're doing here, but this whole "is isolated text node" logic (which predates this PR) is kind of wrong. 🙂 What we need to do instead is:
- Find all adjacent text nodes (and comment nodes, if not running in
lwc:preserve-commentsmode) - Generate code to concatenate them together at runtime (including literals and expressions!)
- If the result is the empty string, then generate the ZWJ character instead
This would be required if we want to fix all the test failures. 🙂
There was a problem hiding this comment.
@nolanlawson sounds good. So you're saying it's better to figure out that solution than to push this one first?
There was a problem hiding this comment.
No no, it's fine; this is progress. :) BTW we were tackling the same thing today: #4963
cardoso
commented
Nov 26, 2024
packages/@lwc/ssr-compiler/src/compile-template/transformers/text.ts
Outdated
Show resolved
Hide resolved
|
/nucleus test |
nolanlawson
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes 5 expected failures:
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item