fix(ssr): non-top-level light slots with if:true
#4967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 27, 2024
| }); | ||
| const slotContent = irToEs(clone, cxt); | ||
| results.push(b.expressionStatement(bAddLightContent(slotName, null, slotContent))); | ||
| }; |
There was a problem hiding this comment.
This logic is a bit hard to read, and the types are abysmal, but I thought I'd put the PR up anyway and fix it later. Now you know how my twisted mind works. 😆
wjhsf
approved these changes
Nov 27, 2024
| @@ -62,6 +73,84 @@ const bAddLightContent = esTemplate` | |||
| }); | |||
| `<EsCallExpression>; | |||
|
|
|||
| // Light DOM slots are a bit complex because of needing to handle slots _not_ at the top level | |||
There was a problem hiding this comment.
Might be helpful to include a mini example in this explanation.
packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
Outdated
Show resolved
Hide resolved
packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
Outdated
Show resolved
Hide resolved
…omponent/slotted-content.ts Co-authored-by: Will Harney <[email protected]>
…omponent/slotted-content.ts Co-authored-by: Will Harney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes some bugs with light DOM slots not at the top level, but only for
if:true. The problem withlwc:ifis that it requires generating HTML comment bookends conditionally, which needs more work to finish.This PR is a modest fix to problems with non-top-level slots, but it's a start.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?