Auto include through associations when 'middle' association was loaded but not modified #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d but not modified (salsify#138) When an association goes through another association, e.g. `has_many :tags, through: :post_tags`, loading the `post_tags` association was enough, to not auto include the `tags` association when it is first accessed. This is correct for when the `post_tags` association was modified and auto include could lead to weird results. When nothing was modified it is totally fine to auto include the through association. Code author: Felix Tscheulin https://github.com/Flixt
|
Not sure what happened in #143, but now it should work :D |
jturkel
approved these changes
May 30, 2024
|
@viktorianer - This has been released in 4.2.1. |
viktorianer
deleted the
fix/auto-include-through-associations-when-middle-association-was-loaded
branch
|
Thanks a lot, Joel and @Flixt. I could already recheck this, and it works with 4.x too 💯 👍🏼. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an association goes through another association, e.g.
has_many :tags, through: :post_tags, loading thepost_tagsassociation was enough, to not auto include thetagsassociation when it is first accessed.This is correct for when the
post_tagsassociation was modified and auto include could lead to weird results. When nothing was modified it is totally fine to auto include the through association.Code author: Felix Tscheulin https://github.com/Flixt
Backport for #138