Set DB transactions to read-only and provide messaging for non-read operations #21
Conversation
| module PostgreSQLAdapter | ||
| def begin_db_transaction | ||
| super | ||
| execute 'SET TRANSACTION READ ONLY' |
There was a problem hiding this comment.
What happens if someone tries to select for update in this mode?
There was a problem hiding this comment.
PG::ReadOnlySqlTransaction: ERROR: cannot execute SELECT FOR UPDATE in a read-only transaction
There was a problem hiding this comment.
Would that behavior break certain code-paths?
There was a problem hiding this comment.
Cool just wanted to ensure this covers locking in read statements also. I'm not aware of anything that would break.
Do you typically use this locally to manually verify your changes? If you run a couple commands that way and everything behaves properly I think that's enough code-path validation.
There was a problem hiding this comment.
Yep, I manually verify locally for in-house Salsify apps.
I could build out the feature tests here and have fancier rails fixtures, but it'd be extremely difficult to capture all the various use-cases that this should be catching. Would be a nice-to-have though.
This fixes #18 and also fixes #19 , where transactions are always read-only in sandbox (read-only) mode. Clearer messaging is added when a user tries to make a non-read operation.
prime: @cjf2xn