Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redhat): set NAMEDCONF file in sysconfig #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rgroux
Copy link

@rgroux rgroux commented Sep 20, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This feature add the possibility to set the config file to use in the sysconfig file for redhat family system

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

in the pillar we can add bind:lookup:config entry and use it for the sysconfig.

@rgroux rgroux changed the title feature(redhat): set NAMEDCONF file in sysconfig feat(redhat): set NAMEDCONF file in sysconfig Sep 23, 2024
Add the possibility to set named config file into sysconfig default file
@rgroux rgroux requested a review from a team as a code owner October 30, 2024 14:56
@rgroux
Copy link
Author

rgroux commented Oct 30, 2024

This projet is still alive or not? the test for PR use some obsolete OS like debian 9 (with no security repository) and failed because of the test setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant