Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fullchain-privkey.pem file creation and update #12

Merged

Conversation

lgunsch
Copy link

@lgunsch lgunsch commented Apr 4, 2016

This adds a step to create a fullchain-priv.pem PEM file for each domain, which can then be used with Pound (load balancer and SSL termination).

It also updates the fullchain-priv.pem file every time the domains are renewed.

/usr/local/bin/renew_letsencrypt_cert.sh:
file.managed:
- mode: 755
- contents: |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for readability can you make this an actual file sourced in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetk Okay, I have made this a templated file now and sourced it in.

@iggy
Copy link

iggy commented Apr 30, 2016

What kind of testing was done on this? (late to the game, I know)

@lgunsch
Copy link
Author

lgunsch commented Apr 30, 2016

@iggy I fully tested it on a server of mine with a live domain that previously didn't have a certificate. I tested that the fullchain-privkey.pem could be properly used by Pound. I also tested the bash scripts on another server with 5 real domains, but it is not managed by Salt at the moment.

@iggy
Copy link

iggy commented May 1, 2016

Thanks.

@iggy iggy merged commit 85e3f49 into saltstack-formulas:master May 1, 2016
@emansom
Copy link

emansom commented May 7, 2022

Certbot supports post deployment hooks via the /etc/letsencrypt/renewal-hooks directory. Might this be moved there?
That way no reliance on cron nessecary.

Useful for masterless setups, that now might get a broken cert after some time, if they are relying on the fullchain-privkey.pem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants