feat(domains): allow to specify different authenticators/installers #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierbertoli
force-pushed
the
allow-mixing-authenticators
branch
2 times, most recently
from
a1be797 to
1b58e74
Compare
Closed
Allow to specify different authenticators or installers for each domainset. Also, added a `pebble` ACME CA to test that the domainsets can be obtained and installed correctly. Added tests to verify the certificates are installed.
javierbertoli
force-pushed
the
allow-mixing-authenticators
branch
from
3cadbaf to
2870ada
Compare
javierbertoli
force-pushed
the
allow-mixing-authenticators
branch
from
2870ada to
c3637f7
Compare
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Fixes #14
Describe the changes you're proposing
Added a couple of extra paramters (
letsencrypt:authenticatorsandletsencrypt:installers) that allow to specify different authenticators or installers for each domainset.This lets you manage, in a single server, vhosts that authenticate using a local webserver (ie, nginx) and vhosts that authenticate using other methods (ie, route53).
Added a
pebbleACME CA to the testing infrastructure, so now we can test that the domainsets are obtained and installed correctly.Added tests to verify the certificates are obtained and installed correctly.
Pillar / config required to test the proposed changes
See https://github.com/saltstack-formulas/letsencrypt-formula/blob/master/test/salt/pillar/domains.sls
and https://github.com/saltstack-formulas/letsencrypt-formula/blob/master/pillar.example
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context