-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(semantic-release): implement an automated changelog #415
Conversation
The big one! I was wondering who was going to be brave enough for this challenge... |
not such a challenge in reality. Easier than postfix/apt formulas that I tried yesterday... because tests are already OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, sorry about all of the documentation comments!
docs/CONTRIBUTING.rst
Outdated
packages. | ||
|
||
|
||
Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our mini-discussion above, you're not going to be pleased to find out that we remove everything after that point, including this Documentation
section...
docs/README.rst
Outdated
salt-formula | ||
============ | ||
|
||
|img_travis| |docs| |img_sr| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|img_travis| |docs| |img_sr| | |
|img_travis| |img_sr| |
docs/README.rst
Outdated
.. |docs| image:: https://readthedocs.org/projects/docs/badge/?version=latest | ||
:alt: Documentation Status | ||
:scale: 100% | ||
:target: https://salt-formula.readthedocs.io/en/latest/?badge=latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And coupled with that suggestion above, removing these four lines to do with |docs|
.
docs/index.rst
Outdated
@@ -0,0 +1,20 @@ | |||
.. _index: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file to be removed since it's unused.
plus docs on contributing, testing
Brillant, thanks @daks -- merged. |
@daks thanks for this, nice work !!!!! |
🎉 This PR is included in version 0.57.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
"Yes, Salt can release itself!"