Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkgs_spec): update for 2019.2.1 release #438

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

myii
Copy link
Member

@myii myii commented Sep 25, 2019

@myii myii force-pushed the test/update-for-2019-2-1 branch from 5acb356 to 1bf9689 Compare September 25, 2019 20:01
@myii myii merged commit f428ce4 into saltstack-formulas:master Sep 25, 2019
@myii myii deleted the test/update-for-2019-2-1 branch September 25, 2019 22:09
@saltstack-formulas-travis

🎉 This PR is included in version 0.59.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aboe76
Copy link
Member

aboe76 commented Sep 26, 2019

@myii, this is quick, having this matrix in the salt-formula, will definitely help !!! Catching regressions early.

@myii
Copy link
Member Author

myii commented Sep 26, 2019

@aboe76 It had to be done, as soon as the new packages were available in the repo, the tests started failing here! It wasn't much to do but it had to be done immediately.

@myii
Copy link
Member Author

myii commented Sep 26, 2019

@aboe76 Oh, do you mean having the full matrix of 2019.2.x instances? That was only for testing this PR. Or are you suggesting that it should be used for the formula the whole time? The only problem is, we already have 8 instances selected, to try to cover the various combinations of OS and Salt version. So we're still with this matrix:

Let me know if you have any further suggestions.

@aboe76
Copy link
Member

aboe76 commented Sep 26, 2019

@myii I don't think some distributions are that quick, but if we can have one distribution that's quickly with new salt releases maybe we can add that one to test early and catch maybe some regression in our formula against a newer version of salt.

@myii
Copy link
Member Author

myii commented Sep 26, 2019

@aboe76 Do you have any suggestions? This first Travis run showed the distributions that had the quickest updates, i.e.:

So that's debian, ubuntu, centos and amazonlinux.

@javierbertoli has got centos-8 and 2019.2.1 pre-salted images coming out soon, so we can revisit the ordering in the matrix when that is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants