Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vagrant): switch image #444

Merged
merged 1 commit into from
Dec 13, 2019
Merged

refactor(vagrant): switch image #444

merged 1 commit into from
Dec 13, 2019

Conversation

MSeven
Copy link
Contributor

@MSeven MSeven commented Dec 11, 2019

  • add Vagrant temp files to .gitignore
  • Update Vagrant Basebox to bento/ubuntu-18.04 (bento images deliver better Vagrant integration)
  • Update Vagrant setup-salt.sh to use the current salt bootstrap script.
    Upgrade vagrant environnement  #347

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

	* add Vagrant temp files to .gitignore
	* Update Vagrant Basebox to bento/ubuntu-18.04 (bento images deliver better Vagrant integration)
	* Update Vagrant setup-salt.sh to use the current salt bootstrap script.
@myii myii requested a review from aboe76 December 13, 2019 07:35
@aboe76
Copy link
Member

aboe76 commented Dec 13, 2019

@MSeven could you rename your PR: refactor(vagrant): switch image
So the test will go smoothly,

I don't mind switching the default vagrant image to this project bento images.
we are already testing salt code on custom images.

@MSeven MSeven changed the title Vagrant Updates: refactor(vagrant): switch image Dec 13, 2019
@MSeven
Copy link
Contributor Author

MSeven commented Dec 13, 2019

Sure thing.

@aboe76 aboe76 merged commit eb192f4 into saltstack-formulas:master Dec 13, 2019
@aboe76
Copy link
Member

aboe76 commented Dec 13, 2019

@MSeven thanks for this

@saltstack-formulas-travis

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants