benchmark: remove unreachable return

PR-URL: nodejs#25883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
sam-github · Feb 7, 2019 · b4e670d · b4e670d
1 parent 4e07d21
commit b4e670d
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 6 deletions.
diff --git a/benchmark/_cli.js b/benchmark/_cli.js
@@ -70,7 +70,6 @@ function CLI(usage, settings) {
     } else {
       // Bad case, abort
       this.abort(usage);
-      return;
     }
   }
 }

diff --git a/benchmark/common.js b/benchmark/common.js
@@ -169,7 +169,6 @@ Benchmark.prototype._run = function() {
     child.on('close', (code) => {
       if (code) {
         process.exit(code);
-        return;
       }
 
       if (queueIndex + 1 < self.queue.length) {

diff --git a/benchmark/compare.js b/benchmark/compare.js
@@ -25,7 +25,6 @@ const cli = CLI(`usage: ./node compare.js [options] [--] <category> ...
 
 if (!cli.optional.new || !cli.optional.old) {
   cli.abort(cli.usage);
-  return;
 }
 
 const binaries = ['old', 'new'];
@@ -98,7 +97,6 @@ if (showProgress) {
   child.once('close', (code) => {
     if (code) {
       process.exit(code);
-      return;
     }
     if (showProgress) {
       progress.completeRun(job);

diff --git a/benchmark/run.js b/benchmark/run.js
@@ -67,7 +67,6 @@ if (format === 'csv') {
   child.once('close', (code) => {
     if (code) {
       process.exit(code);
-      return;
     }
 
     // If there are more benchmarks execute the next

diff --git a/benchmark/scatter.js b/benchmark/scatter.js
@@ -17,7 +17,6 @@ const cli = CLI(`usage: ./node scatter.js [options] [--] <filename>
 
 if (cli.items.length !== 1) {
   cli.abort(cli.usage);
-  return;
 }
 
 // Create queue from the benchmarks list such both node versions are tested
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,7 +70,6 @@ function CLI(usage, settings) { @@
         } else {
           // Bad case, abort
           this.abort(usage);
-          return;
         }
       }
     }
@@ Expand Down @@