smbcc: Add 'dos charset' option to Global smb.conf defaults #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'dos charset' option allows us to specify a particular charset which in turn helps to avoid the following warning message on clients in the absence of 850 charset: "dos charset 'CP850' unavailable - using ASCII" Signed-off-by: Anoop C S <[email protected]>
phlogistonjohn
approved these changes
Jul 5, 2022
|
/test centos-ci/sink-clustered/mini-k8s-1.24 |
There is an ongoing issue with CentOS CI environment where jenkins pod is getting restarted frequently. This can coincide with jobs running around that time which initially caused failure here. Hopefully the next run goes through well. |
|
OK, threre's also an open-coded uses of smbclient package in mount_path_test.go that I didn't notice before. I'm filing an issue on that and will follow up. |
|
Filed #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dos charsetoption allows us to specify a particular charset which in turn helps to avoid the following warning message on clients in the absence of 850 charset: