Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: add image annotations #277

Merged

Conversation

synarete
Copy link
Collaborator

@synarete synarete commented Feb 6, 2023

Use standard image-spec annotations[1] to define minimal reference to SINK project within the samba-operator image itself.

[1] https://github.com/opencontainers/image-spec/blob/main/annotations.md

Signed-off-by: Shachar Sharon [email protected]

phlogistonjohn
phlogistonjohn previously approved these changes Feb 7, 2023
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

anoopcs9
anoopcs9 previously approved these changes Feb 8, 2023
@anoopcs9
Copy link
Collaborator

anoopcs9 commented Feb 8, 2023

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Feb 8, 2023

refresh

✅ Pull request refreshed

@phlogistonjohn
Copy link
Collaborator

mergify failed because of an indentation issue. See #278

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Feb 9, 2023

@Mergifyio rebase

Use standard image-spec annotations[1] to define minimal reference to
SINK project within the samba-operator image itself.

[1] https://github.com/opencontainers/image-spec/blob/main/annotations.md

Signed-off-by: Shachar Sharon <[email protected]>
@mergify
Copy link

mergify bot commented Feb 9, 2023

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@mergify
Copy link

mergify bot commented Feb 9, 2023

rebase

✅ Branch has been successfully rebased

@spuiuk spuiuk dismissed stale reviews from anoopcs9 and phlogistonjohn via 15ccdf0 February 9, 2023 09:28
@spuiuk spuiuk force-pushed the ss-dockerfile-annotations branch from 1b4b343 to 15ccdf0 Compare February 9, 2023 09:28
@mergify mergify bot merged commit 199419a into samba-in-kubernetes:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants