Install ruby from source #2429
Merged
Install ruby from source #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoluter
reviewed
Oct 9, 2021
asoluter
reviewed
Oct 9, 2021
`bundler 2.1.4` is default gem of ruby >= 2.7.1 and installed during ruby installation so we don't need to install it explicitly.
|
Hi, I'll merge your PR later in the evening. Sorry for the delay. |
I think that defining a variable for the source of the Ruby tarball makes sense.
|
Thanks. I can create pull request for 14.3.0 just now |
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Dec 9, 2021
followup of Merge pull request sameersbn#2429 image size : 2.83GB / 14.4.1 is 2.69GB I will try to make smaller ..
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Dec 10, 2021
followup of Merge pull request sameersbn#2429 image size : 2.83GB / 14.4.1 is 2.69GB I will try to make smaller ..
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Dec 24, 2021
followup of Merge pull request sameersbn#2429 image size : 2.83GB / 14.4.1 is 2.69GB I will try to make smaller ..
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Jan 4, 2022
followup of Merge pull request sameersbn#2429 image size : 2.83GB / 14.4.1 is 2.69GB I will try to make smaller ..
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Jan 11, 2022
followup of Merge pull request sameersbn#2429 image size : 2.83GB / 14.4.1 is 2.69GB I will try to make smaller ..
kkimurak
pushed a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Jan 23, 2023
for caching We have started installing ruby from source at first (5266396) then migrated to official ubuntu ppa (125814d) and then brightbox/ruby-ng repo (d4ae3c4), finally back to source installation (sameersbn#2429). In work sameersbn#2429 the installation process is written in install.sh, but, at the beginning, that were in Dockerfile.
kkimurak
pushed a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Feb 3, 2023
for caching We have started installing ruby from source at first (5266396) then migrated to official ubuntu ppa (125814d) and then brightbox/ruby-ng repo (d4ae3c4), finally back to source installation (sameersbn#2429). In work sameersbn#2429 the installation process is written in install.sh, but, at the beginning, that were in Dockerfile.
kkimurak
pushed a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Feb 7, 2023
for caching We have started installing ruby from source at first (5266396) then migrated to official ubuntu ppa (125814d) and then brightbox/ruby-ng repo (d4ae3c4), finally back to source installation (sameersbn#2429). In work sameersbn#2429 the installation process is written in install.sh, but, at the beginning, that were in Dockerfile.
kkimurak
added a commit
to kkimurak/docker-gitlab
that referenced
this pull request
Feb 7, 2023
for caching We have started installing ruby from source at first (5266396) then migrated to official ubuntu ppa (125814d) and then brightbox/ruby-ng repo (d4ae3c4), finally back to source installation (sameersbn#2429). In work sameersbn#2429 the installation process is written in install.sh, but, at the beginning, that were in Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab 14.3.0 requires
ruby> = 2.7.4. This image uses therubypackage of ppa since commit 125814d (migrated tobrightbox/ruby-ngsince d4ae3c4), but it hasn't been updated for 40 weeks after updating ruby2.7 to 2.7.2.I think this is one of the reasons behind the delay in the release of this image.
With this patch, this image will install ruby by building from source instead of
apt.update: Also,
rubywill be updated to2.7.4from2.7.2in this PR.This is alternative way of #2428 to prepare GitLab 14.3.0. I have also tested this patch with 14.2.3, 14.2.4 and 14.3.0 (I simply updated
rubyto 2.7.4 when I test 14.3.0).