-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sock_diag(7)
: Netlink support for AF_INET & IPPROTO_TCP
#25
Draft
saminiir
wants to merge
35
commits into
master
Choose a base branch
from
devel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enforced by e.g. the `ss` tool.
This is an error with clang, so avoid it.
This is the order Linux header uses, so let's switch to it.
This is more accurate than protocol, since e.g. SOCK_STREAM implies TCP
This change is introduced because suddenly CAP_NET_ADMIN stopped working for my Arch Linux. In essence, doing $ sudo setcap cap_net_admin=ep $(which ip) Has no effect anymore: $ ip link set dev tap0 up RTNETLINK answers: Operation not permitted Searching the Internet, one error case is if the directory is mounted with `nosuid`, but this does not seem to be the case in my Linux.
Since iproute2 changed its capability handling, seems like it is simpler to just guide the user to create the tap device itself. This is also what Google's Netstack does. iproute2/iproute2@9b13cc9
This reverts commit 72e4c27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Netlink AF_INET/IPPROTO_TCP socket information gathering. See
man sock_diag
.Useful with the
ss
tool (fromiproute2
):