Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify's PollWatcher with_delay removed #144

Closed
davidbrochart opened this issue May 17, 2022 · 5 comments · Fixed by #146
Closed

Notify's PollWatcher with_delay removed #144

davidbrochart opened this issue May 17, 2022 · 5 comments · Fixed by #146
Labels

Comments

@davidbrochart
Copy link
Collaborator

Description

The conda package fails to compile watchfiles v0.14 because if downloads notify v5.0.0-pre.15. I'm not sure why since it is v5.0.0-pre.14 in Cargo.toml.
And with_delay has been removed in notify v5.0.0-pre.15.

Example Code

No response

Example Code Output

No response

Operating System

Ubuntu 22.04

Environment

No response

Watchfiles Version

v0.14

Python Version

3.10

@samuelcolvin
Copy link
Owner

Fun, and weird.

Should be easy enough to remove it.

@samuelcolvin
Copy link
Owner

Is it worth asking the conda people why the wrong rust package was downloaded?

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented May 17, 2022

It's because of this:

Cargo allows "newer" pre-releases to be used automatically. For example, if 1.0.0-beta is published, then a requirement foo = "1.0.0-alpha" will allow updating to the beta version.

@samuelcolvin
Copy link
Owner

😞 I really don't understand why notify is versioned the way it is.

I'll fix this and create an issue asking for a proper release ok notify.

@samuelcolvin
Copy link
Owner

should be fixed by #146, once that's merged we can release a patch version.

samuelcolvin added a commit that referenced this issue May 17, 2022
* support notify 5.0.0-pre.15, fix #144

* pin to exact notify pre-release

Co-authored-by: Pavan Kumar Sunkara <[email protected]>

Co-authored-by: Pavan Kumar Sunkara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants