[email protected] #232

davidchambers · 2016-06-13T05:36:41Z

This pull request:

makes the Either and Maybe types compatible with Fantasy Land v2.2.x;
removes type checking from Either and Maybe methods;
removes the Ramda dependency;
defines S.__;
adds sanctuary-type-classes as a dependency; and
updates the sanctuary-def dependency to v0.8.0 (as described below).

Original description:

This pull request is not yet ready to merge since [email protected] is not yet available, but I couldn't wait any longer to share this. We now have the ability to describe higher-order functions via sanctuary-def!
S.find(x => x, ['foo', 'bar', 'baz']);
// ! TypeError: Invalid value
//
//   find :: (a -> Boolean) -> Array a -> Maybe a
//                 ^^^^^^^
//                    1
//
//   1)  "foo" :: String
//
//   The value at position 1 is not a member of ‘Boolean’.
Consider the updated type of find:
-[$.Function, $.Array(a), $Maybe(a)]
+[Fn(a, $.Boolean), $.Array(a), $Maybe(a)]
What we currently know as $.Function is to be renamed $.AnyFunction. $.Function will be a type constructor of type Array Type -> Type – $.Function([$.String, $.Integer]), for example, will represent String -> Integer. Since curried functions are so common in the Sanctuary codebase I defined Fn :: (Type, Type) -> Type so we can write Fn(a, Fn(b, c)) rather than the noisy $.Function([a, $.Function([b, c])]).

@Avaq, you'll be able to update #191 once this pull request has been merged. :)

The one other sanctuary-def feature I would like to add before publishing the next version is support for parameterized type variables. That will mean we can accurately describe the type of a function such as lift :: Functor f => (a -> b) -> f a -> f b!

davidchambers · 2016-06-13T17:04:42Z

I added $.UnaryTypeVariable to sanctuary-def, so the type of lift is now [Fn(a, b), f(a), f(b)] with the constraint {f: [Functor]}. 🎉

davidchambers · 2016-11-16T02:23:34Z

test/on.js

@@ -11,6 +11,7 @@ describe('on', function() {
  it('is a quaternary function', function() {
    eq(typeof S.on, 'function');
    eq(S.on.length, 4);
+    eq(S.on.toString(), 'on :: (b -> b -> c) -> (a -> b) -> a -> a -> c');


It's exciting to be able to express the types of functions such as this one, @Bradcomp. :)

davidchambers · 2017-01-03T08:03:28Z

karma.conf.js

+var dependencies = ['sanctuary-type-classes', 'sanctuary-def'];
+
+eq(dependencies.slice().sort(),
+   Object.keys(require('./package.json').dependencies).sort());


@Shard, this is my low-tech fix for #309. How does it look to you?

Yea this is probably the better way now that I think about it, just having a test check if things are out of sync.

👍

davidchambers · 2017-01-03T08:14:56Z

index.js

-//. makes it possible to write safe code without null checks.
+//. Sanctuary is a functional programming library inspired by Haskell
+//. and PureScript. It's stricter and more opinionated than [Ramda][].
+//. Sanctuary makes it possible to write safe code without null checks.


@Jacse, let's collaborate. I like your changes in #317, but since this pull request removes our Ramda dependency we must update the introduction accordingly. Feel free to suggest changes and/or additions to the paragraph above. :)

@davidchambers looks good, but maybe we should mention that Sanctuary can/should be used as an alternative to Ramda. On the top of my head: "It includes much the same functionality as Ramda, but is stricter and more opinionated."

I think this would make it more clear what functionality people can expect from Sanctuary ("write safe code without null checks" can be a bit vague). Most likely developers diving into functional programming in javascript will take a look at both Ramda and Sanctuary and I think a wording along these lines would make the relationship between them clear.

Just my 2 cents.

I like it. I'll make the change you have proposed.

When Sanctuary first came into existence it was focused on avoiding the null checks which several Ramda functions require. Sanctuary's scope is now much broader.

I've updated the introduction. I went with "provides a similar suite of functions" rather than "includes much the same functionality".

@davidchambers yeah that's better.

svozza · 2017-01-03T08:06:12Z

test/Either/Left.js

-  test('"sequence" method', function() {
-    eq(S.Left('abc').sequence.length, 1);
-    eq(S.Left('abc').sequence(S.Maybe.of), S.Just(S.Left('abc')));
+  test('"fantasy-land/reduce" method', function() {


What happened to sequence?

See #257 for the discussion which led to its removal.

Ah, I missed that one.

svozza · 2017-01-03T08:10:36Z

test/Maybe/Nothing.js

-           '1)  null :: Null\n' +
-           '\n' +
-           'The value at position 1 is not a member of ‘Function’.\n');
+  test('"fantasy-land/extend" method', function() {


What about filter?

This was also discussed in #257.

svozza · 2017-01-03T08:27:12Z

test/indexOf.js

-         '1)  null :: Null\n' +
-         '\n' +
-         'The value at position 1 is not a member of ‘List a’.\n');
+  eq(S.indexOf.toString(), 'indexOf :: a -> List a -> Maybe Integer');


I'm a bit confused as to what the criteria are for using Array over List in various type signatures. indexOf seems to me to be more an array function than a list one given how expensive it is for the latter data structure.

I believe the List type in Sanctuary is just a union of Array, String and other types with a length, excluding functions. The type signature has Array when the function would not work on all of these other types as well; https://sanctuary.js.org/#list

The List type attempts to unify $.Array and $.String. It doesn't have anything to do with linked lists. It's a confusing type, certainly!

List

The List type constructor enables type signatures to describe ad hoc polymorphic functions which operate on either Array or String values.

Mental gymnastics are required to treat arrays and strings similarly. [1, 2, 3] is a list containing 1, 2, and 3. 'abc' is a list containing 'a', 'b', and 'c'. But what is the type of 'a'? String, since JavaScript has no Char type! Thus:

'abc' :: String, List String, List (List String), ...

Every member of String is also a member of List String! This affects the interpretation of type signatures. Consider the type of indexOf:

a -> List a -> Maybe Integer

Assume the second argument is 'hello' :: List String. a must then be replaced with String:

String -> List String -> Maybe Integer

Since List String and String are interchangeable, the former can be replaced with the latter:

String -> String -> Maybe Integer

It's then apparent that the first argument needn't be a single-character string; the correspondence between arrays and strings does not hold.

As for S.indexOf and S.lastIndexOf, I'd really like to remove these functions. Addressing array elements by index is not a practice we should encourage.

Addressing array elements by index is not a practice we should encourage

🏅

Ah yes, I vaguely remember the discussions we had about List a few months ago now.

davidchambers · 2017-01-12T05:46:31Z

index.js

-  //  negativeZero :: a -> Boolean
-  var negativeZero = R.either(R.equals(-0), R.equals(new Number(-0)));
+  //  Thunk :: Type -> Type
+  function Thunk(x) { return $.Function([x]); }


@safareli, we can replace $.Function([x]) with $.Thunk(x) once sanctuary-def supports this. :)

davidchambers mentioned this pull request Jun 13, 2016

either: implement Foldable #204

Merged

davidchambers force-pushed the dc-sanctuary-def branch from b3d6c3f to 8adf925 Compare June 13, 2016 17:00

davidchambers force-pushed the dc-sanctuary-def branch from 8adf925 to b2c2a11 Compare June 23, 2016 23:45

This was referenced Jun 26, 2016

define $.Function and $.UnaryTypeVariable sanctuary-js/sanctuary-def#79

Merged

Add S.mean that calculates mean of values of a foldable #234

Merged

davidchambers force-pushed the dc-sanctuary-def branch 2 times, most recently from acfe6fa to 9c421cc Compare July 5, 2016 04:53

davidchambers force-pushed the dc-sanctuary-def branch from 9c421cc to a4f2c43 Compare August 2, 2016 16:27

davidchambers mentioned this pull request Sep 14, 2016

v0.12.0 checklist #255

Closed

33 tasks

davidchambers force-pushed the dc-sanctuary-def branch from a4f2c43 to 346ef94 Compare September 14, 2016 02:31

davidchambers force-pushed the dc-sanctuary-def branch 2 times, most recently from 4e22761 to 89f3a75 Compare September 28, 2016 11:42

davidchambers mentioned this pull request Oct 1, 2016

ADTs defined using S functions are compatible only with types known to S #262

Closed

davidchambers force-pushed the dc-sanctuary-def branch 4 times, most recently from 5790ed7 to a367dd0 Compare October 2, 2016 13:50

davidchambers force-pushed the dc-sanctuary-def branch 2 times, most recently from 6d72f19 to 472eecd Compare October 11, 2016 17:34

davidchambers mentioned this pull request Oct 15, 2016

Built-in unary MaybeType from sanctuary causing errors when used in sig sanctuary-js/sanctuary-def#87

Closed

davidchambers force-pushed the dc-sanctuary-def branch 2 times, most recently from 4567a75 to fd83fe1 Compare October 16, 2016 11:21

davidchambers force-pushed the dc-sanctuary-def branch 4 times, most recently from 1301d5b to 4f849d6 Compare November 4, 2016 14:36

davidchambers mentioned this pull request Nov 15, 2016

Fantasy Land method aliases #257

Closed

davidchambers force-pushed the dc-sanctuary-def branch from 0e29d81 to 836c8e3 Compare November 16, 2016 02:20

davidchambers commented Nov 16, 2016

View reviewed changes

davidchambers commented Jan 3, 2017

View reviewed changes

svozza reviewed Jan 3, 2017

View reviewed changes

svozza approved these changes Jan 3, 2017

View reviewed changes

davidchambers force-pushed the dc-sanctuary-def branch from 61c759e to 1f2f964 Compare January 3, 2017 10:06

Jacse mentioned this pull request Jan 4, 2017

Clarify Ramda <-> Sanctuary relationship #317

Merged

davidchambers force-pushed the dc-sanctuary-def branch 11 times, most recently from 1c4a09d to 5b277bf Compare January 12, 2017 04:52

davidchambers force-pushed the dc-sanctuary-def branch 4 times, most recently from 4c96b25 to 76aaed2 Compare January 12, 2017 05:44

davidchambers commented Jan 12, 2017

View reviewed changes

davidchambers force-pushed the dc-sanctuary-def branch 2 times, most recently from 726a105 to 5d37f9b Compare January 12, 2017 06:06

[email protected]

5c2ca39

davidchambers force-pushed the dc-sanctuary-def branch from 5d37f9b to 5c2ca39 Compare January 12, 2017 06:18

davidchambers merged commit 35ed837 into master Jan 12, 2017

davidchambers deleted the dc-sanctuary-def branch January 12, 2017 06:32

davidchambers mentioned this pull request Feb 13, 2017

v0.12.0 release notes #332

Closed

davidchambers mentioned this pull request Mar 6, 2018

logic: remove vestigial support for Boolean objects #496

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[email protected] #232

[email protected] #232

davidchambers commented Jun 13, 2016 •

edited

Loading

davidchambers commented Jun 13, 2016

davidchambers Nov 16, 2016

davidchambers Jan 3, 2017

Shard Jan 3, 2017

davidchambers Jan 3, 2017

Jacse Jan 3, 2017

davidchambers Jan 3, 2017

davidchambers Jan 5, 2017

Jacse Jan 6, 2017

svozza Jan 3, 2017

davidchambers Jan 3, 2017

svozza Jan 3, 2017

svozza Jan 3, 2017

davidchambers Jan 3, 2017

svozza Jan 3, 2017

Avaq Jan 3, 2017 •

edited

Loading

davidchambers Jan 3, 2017

Avaq Jan 3, 2017

svozza Jan 3, 2017

davidchambers Jan 12, 2017

[email protected] #232

[email protected] #232

Conversation

davidchambers commented Jun 13, 2016 • edited Loading

davidchambers commented Jun 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Avaq Jan 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidchambers commented Jun 13, 2016 •

edited

Loading

Avaq Jan 3, 2017 •

edited

Loading