Static imports to aid bundle traversing tools #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| /* istanbul ignore else */ | ||
| if (typeof module === 'object' && typeof module.exports === 'object') { | ||
| module.exports = f(require(deps[0]), require(deps[1]), require(deps[2])); | ||
| module.exports = f(require('sanctuary-def'), require('sanctuary-type-classes'), require('sanctuary-type-identifiers')); |
There was a problem hiding this comment.
I expect the linter to complain about the length of this line. If so, let's use this instead:
module.exports = f(require('sanctuary-def'),
require('sanctuary-type-classes'),
require('sanctuary-type-identifiers'));
Something like this too @davidchambers ? |
|
Also noticed this in the
|
index.js
Outdated
| define(deps, f); | ||
| define(['sanctuary-def', | ||
| 'sanctuary-type-classes', | ||
| 'sanctuary-type-identifiers'], f); |
There was a problem hiding this comment.
My rule for line wrapping is that expressions at the same level semantically should be at the same level visually. I'd prefer this wrapping:
define(['sanctuary-def',
'sanctuary-type-classes',
'sanctuary-type-identifiers'],
f);I seem to recall introducing deps to avoid the above, because f looked lonely. 😢
@JAForbes, could you make this change and squash your commits while you're at it? I'll then merge this pull request and release v0.12.1. :)
JAForbes
force-pushed
the
jf-browser-builds
branch
from
536ff7c
to
ccb9252
Compare
Browserify requires static imports in order to establish a dependency tree.
davidchambers
force-pushed
the
jf-browser-builds
branch
from
ccb9252
to
e111f59
Compare
|
🌳 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browserify require static import's in order to establish a dependency tree.
This PR addresses this issue by replacing e.g.
require(deps[0])withrequire('sanctuary-def')