[java] use Files.notExists to check files SeleniumHQ#14088

sandeepsuryaprasad · Oct 29, 2024 · 3d7b6b4 · 3d7b6b4
1 parent 84ad63b
commit 3d7b6b4
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/java/src/org/openqa/selenium/internal/Require.java b/java/src/org/openqa/selenium/internal/Require.java
@@ -442,7 +442,9 @@ public Path isFile() {
       if (path == null) {
         throw new IllegalStateException(String.format(MUST_BE_SET, name));
       }
-      if (!Files.exists(path)) {
+      // notExists returns false in case it is impossible to determinate the exact result of a link
+      // target e.g. Windows app execution aliases
+      if (Files.notExists(path)) {
         throw new IllegalStateException(String.format(MUST_EXIST, name, path));
       }
       if (!Files.isRegularFile(path)) {
@@ -455,7 +457,9 @@ public Path isDirectory() {
       if (path == null) {
         throw new IllegalStateException(String.format(MUST_BE_SET, name));
       }
-      if (!Files.exists(path)) {
+      // notExists returns false in case it is impossible to determinate the exact result of a link
+      // target e.g. Windows app execution aliases
+      if (Files.notExists(path)) {
         throw new IllegalStateException(String.format(MUST_EXIST, name, path));
       }
       if (!Files.isDirectory(path)) {
@@ -468,7 +472,9 @@ public Path isExecutable() {
       if (path == null) {
         throw new IllegalStateException(String.format(MUST_BE_SET, name));
       }
-      if (!Files.exists(path)) {
+      // notExists returns false in case it is impossible to determinate the exact result of a link
+      // target e.g. Windows app execution aliases
+      if (Files.notExists(path)) {
         throw new IllegalStateException(String.format(MUST_EXIST, name, path));
       }
       // do not check for isRegularFile here, there are executable none regular files e.g. Windows